Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MenuItem url to be callable #71

Closed
wants to merge 3 commits into from

Conversation

timnyborg
Copy link
Contributor

Treats url the same way as title, children. Handles cases like #70 without the need for subclassing.

@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #71 (d753e95) into master (5b253e6) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   95.83%   95.98%   +0.15%     
==========================================
  Files           5        5              
  Lines         312      324      +12     
==========================================
+ Hits          299      311      +12     
  Misses         13       13              
Impacted Files Coverage Δ
menu/menu.py 96.94% <100.00%> (+0.04%) ⬆️
menu/tests/test_menu.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b253e6...d753e95. Read the comment docs.

Copy link

@jokiefer jokiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Maybe an explicit example for generating links to object based views would be nice, to avoid missunderstanding the feature of callable url attribute.

Copy link
Member

@kytta kytta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Nothing to change in code from my end. Could you please update the branch to the latest state of master so that the needed CI checks can run?

@kytta kytta mentioned this pull request May 8, 2022
@kytta kytta requested a review from mbeijen May 8, 2022 18:31
@kytta kytta added this to the v2.0.0 milestone May 9, 2022
@kytta kytta closed this in 72e930f Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants