New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix force text enconding support for django 4 #341
Conversation
Hi @diego1996 could you please remove the .idea files? |
Yeah, I hadn't realised. |
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
- Coverage 80.42% 75.57% -4.86%
==========================================
Files 8 8
Lines 470 479 +9
Branches 68 81 +13
==========================================
- Hits 378 362 -16
- Misses 60 82 +22
- Partials 32 35 +3
Continue to review full report at Codecov.
|
Hi @diego1996, I had no problems when including Django 4.0 in the tests matrix, see this PR for tests results: #322 Also, Django 4.0 is deprecating force_text, not force_str: Can you please elaborate on why this PR is needed? |
Thanks for this patch, @diego1996! This PR fixed a Django v4 deprecation issue for me; and it's also written in You should consider merging it to master. Best. |
What is the status on this issue? I'm trying to migrate my project to Django 4.0 and
|
@Blind-Watchmaker according to test results Django main worked but all other versions failed. Patch needs to be adjusted. |
@diego1996 can you please fix the PR? |
@Blind-Watchmaker django-smart-selects 1.6.0 is out and features django 4.0 support. Please let me know if you test it. Thanks! |
Hola chicos, perdon lo tarde, recien lo veo, que bueno que ya se halla solucionado el problema. |
Voy a declinar este PR |
No description provided.