Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChainedSelectMultiple widget doesnt update css on override #349

Merged
merged 1 commit into from May 31, 2023

Conversation

DARKDEYMON
Copy link
Contributor

ChainedSelectMultiple doesn't update de css extra attrs
attrs.update(self.attrs)##< this is missing
attrs["data-chainfield"] = chain_field
attrs["data-url"] = url

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #349 (b8457fd) into master (04a26ef) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
+ Coverage   80.42%   80.46%   +0.04%     
==========================================
  Files           8        8              
  Lines         470      471       +1     
  Branches       81       68      -13     
==========================================
+ Hits          378      379       +1     
  Misses         60       60              
  Partials       32       32              
Impacted Files Coverage Δ
smart_selects/widgets.py 66.48% <100.00%> (+0.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DARKDEYMON DARKDEYMON merged commit 699426b into jazzband:master May 31, 2023
26 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant