-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no way to use tag names with commas in TagField #23
Comments
Not a design decision :) Patch ahoy! |
Awesome. Coming right up. Note that the patch will be slightly backwards-incompatible, in that currently tags must be comma-separated, but with django-tagging's approach if there are no unquoted commas, tags are space-separated. Which means that currently entering "one two three" creates a single tag; with the patch it'll be three tags. Personally I think this is a big improvement, but it should be noted somewhere as a change in behavior. |
Sounds reasonable to me, can you start a changes.html file and note the change there? |
Will do. |
Fixed in HEAD, thanks carljm! |
Erm. I didn't do this yet. Planning to soon, but haven't gotten to it. And it doesn't appear you did it either? |
Ah shit wrong ticket, I can't reopen this either :/ Can you refile? |
GitHub's issue tracker is terrible. And yes, I'll refile :-) |
Hi, Alex, |
Ok this was fixed! |
Which sucks if you happen to have a dataset where tag names are predefined, and some of them must include commas.
django-tagging has a very effective little tag-string parser that handles space-separated tags in the simple case, comma-separated if unquoted commas are found, and allows quoting of tag names that include commas.
Is taggit's "stupid" tagstring parsing a fixed design decision? If not, I'll port tagging's parser, with tests. If so, I'll do it anyway, but keep it in a private branch :-)
The text was updated successfully, but these errors were encountered: