Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no way to use tag names with commas in TagField #23

Closed
carljm opened this issue May 21, 2010 · 10 comments
Closed

no way to use tag names with commas in TagField #23

carljm opened this issue May 21, 2010 · 10 comments

Comments

@carljm
Copy link
Collaborator

carljm commented May 21, 2010

Which sucks if you happen to have a dataset where tag names are predefined, and some of them must include commas.

django-tagging has a very effective little tag-string parser that handles space-separated tags in the simple case, comma-separated if unquoted commas are found, and allows quoting of tag names that include commas.

Is taggit's "stupid" tagstring parsing a fixed design decision? If not, I'll port tagging's parser, with tests. If so, I'll do it anyway, but keep it in a private branch :-)

@alex
Copy link
Collaborator

alex commented May 21, 2010

Not a design decision :) Patch ahoy!

@carljm
Copy link
Collaborator Author

carljm commented May 21, 2010

Awesome. Coming right up. Note that the patch will be slightly backwards-incompatible, in that currently tags must be comma-separated, but with django-tagging's approach if there are no unquoted commas, tags are space-separated. Which means that currently entering "one two three" creates a single tag; with the patch it'll be three tags.

Personally I think this is a big improvement, but it should be noted somewhere as a change in behavior.

@alex
Copy link
Collaborator

alex commented May 21, 2010

Sounds reasonable to me, can you start a changes.html file and note the change there?

@carljm
Copy link
Collaborator Author

carljm commented May 21, 2010

Will do.

@alex
Copy link
Collaborator

alex commented May 28, 2010

Fixed in HEAD, thanks carljm!

@carljm
Copy link
Collaborator Author

carljm commented May 28, 2010

Erm. I didn't do this yet. Planning to soon, but haven't gotten to it. And it doesn't appear you did it either?

@alex
Copy link
Collaborator

alex commented May 28, 2010

Ah shit wrong ticket, I can't reopen this either :/ Can you refile?

@carljm
Copy link
Collaborator Author

carljm commented May 28, 2010

GitHub's issue tracker is terrible. And yes, I'll refile :-)

@idlesign
Copy link
Contributor

Hi, Alex,
Why refile? 'Open' option under 'Actions' dropdown (just below '« Back to Issues' link) doesn't work?

@alex
Copy link
Collaborator

alex commented Jun 4, 2010

Ok this was fixed!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants