Fixed prefetch_related when using UUIDTaggedItem #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #663 +/- ##
==========================================
- Coverage 94.78% 94.67% -0.12%
==========================================
Files 3 3
Lines 422 432 +10
Branches 76 78 +2
==========================================
+ Hits 400 409 +9
Misses 14 14
- Partials 8 9 +1 Continue to review full report at Codecov.
|
|
Great Job:D |
auvipy
approved these changes
Feb 26, 2020
jathanism
added a commit
to jathanism/nautobot
that referenced
this pull request
Jun 8, 2021
Had to change the base class for `TaggedItem` from `GenericTaggedItemBase` to `GenericUUIDTaggedItemBase`, to get the django-taggit machinery to do a UUID-based comparison of the prefetched "tags". Without that the prefetched values weren't matching correctly, and were returning empty. (See: jazzband/django-taggit#663)
jathanism
added a commit
to nautobot/nautobot
that referenced
this pull request
Jun 9, 2021
Had to change the base class for `TaggedItem` from `GenericTaggedItemBase` to `GenericUUIDTaggedItemBase`, to get the django-taggit machinery to do a UUID-based comparison of the prefetched "tags". Without that the prefetched values weren't matching correctly, and were returning empty. (See: jazzband/django-taggit#663) This does not require any migrations because `TaggedItem.object_id` was already changed to a `UUIDField` in a previous commit. This also fixed an issue that was causing tags from emitting in the API entirely. We do not yet have integration tests for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #490