Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Warnings In Browser Inspect #417

Closed
some1ataplace opened this issue Dec 13, 2022 · 7 comments
Closed

Deprecation Warnings In Browser Inspect #417

some1ataplace opened this issue Dec 13, 2022 · 7 comments

Comments

@some1ataplace
Copy link

tinymce.min.js:9 The following deprecated features are currently enabled, these will be removed in TinyMCE 6.0. See https://www.tiny.cloud/docs/release-notes/6.0-upcoming-changes/ for more information.

Plugins:

  • contextmenu
  • spellchecker
  • textcolor

Settings:

  • elements
  • force_p_newlines
  • mode
@claudep
Copy link
Contributor

claudep commented Dec 13, 2022

The fact that TinyMCE removes plugins and replace them by paying functionality doesn't press us to upgrade 😢

@some1ataplace
Copy link
Author

So what will happen to this jazzband project then if we don't upgrade? Can't we remove the same stuff just to keep up to date with the newest tinymce version? Otherwise, what happens if one day in the future tinymce says we no longer support version 5?

I think https://github.com/jazzband/django-tinymce/blob/master/tinymce/static/django_tinymce/init_tinymce.js is somehow automatically appending mode and elements to TINYMCE_DEFAULT_CONFIG even though inside of my TINYMCE_DEFAULT_CONFIG I did not include elements or mode.

When executing these console logs inside init_tinymce.js:

      console.log(mce_conf)
      console.log(el.dataset.mceConf)

I see elements and mode shown along with all my other TINYMCE_DEFAULT_CONFIG settings.

The value of elements and mode is:

mode:"exact"
elements: "id_body"

@claudep
Copy link
Contributor

claudep commented Dec 14, 2022

Deprecated settings are gone for some time, so yes, it would be a welcome improvement. Do you plan to work on a patch?

@some1ataplace
Copy link
Author

Unfortunately I don't really know javascript so I am not sure how to make a patch for it.

claudep added a commit to claudep/django-tinymce that referenced this issue Dec 17, 2022
@claudep
Copy link
Contributor

claudep commented Dec 17, 2022

I would appreciate tests of above pull request.

@some1ataplace
Copy link
Author

I tested the new code changes you made and it made the warnings go away. Thank you!

@claudep
Copy link
Contributor

claudep commented Jan 3, 2024

Was fixed in af4a89c

@claudep claudep closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants