Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyJWT2.0.0a2 supported; 2.0.0 not supported #347

Closed
Andrew-Chen-Wang opened this issue Dec 22, 2020 · 3 comments
Closed

PyJWT2.0.0a2 supported; 2.0.0 not supported #347

Andrew-Chen-Wang opened this issue Dec 22, 2020 · 3 comments

Comments

@Andrew-Chen-Wang
Copy link
Member

Andrew-Chen-Wang commented Dec 22, 2020

Master branch is failing because of what the title says. This issue is going to track it as well as being pinned to make sure people see this before creating an issue. But to reiterate:

Version 4.6.0 (Python 3.7+) supports PyJWT 2.0.0a1, 2.0.0a2, 1.7.1. SimpleJWT does not support PyJWT 2.0.0 as of yet. Please don't create new issues unless this issue is not affecting you.


If you're using Python 3.6 or below, you can only use SimpleJWT 4.4.0 which only supports PyJWT 1.7.1.

@AlexDobrushskiy
Copy link

Here is a PR for this one: #348
It does not resolves the problem of supporting PyJWT 2.0.0, however it resolves the problem of broken applications who use django-rest-framework-simplejwt

@Andrew-Chen-Wang
Copy link
Member Author

Andrew-Chen-Wang commented Dec 23, 2020

@AlexDobrushskiy Thanks for the update. I'd like to update SimpleJWT to 4.7.0 rather than getting a patch out since David's not really active when it comes to maintenance. Will keep it in mind though as I'm patching everything up, though, since I'm not really sure if my time will be enough to update simplejwt.

I guess that's what happens when you increase major versions. Lots of breaking changes.

@Andrew-Chen-Wang
Copy link
Member Author

Ref #349 Unless you wrote verify=False, you aren't effected.

Please note: PyJWT 2.0.0 is supported by SimpleJWT 4.6.0. The master branch tests failed because of certain changes in PyJWT.decode (they started copying the payload first then modifying the copied version), but 4.6.0 is not effected by this change. You should be able to upgrade without a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants