Add PyJWT 2.0.0 support (most are not effected) #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Many tests relied on passing a payload into encode and changing it payload by reference. In PyJWT 2.0.0, the payload is copied (`dict.copy()`). * Verify was deprecated in favor of using the option verify_signature. This is reflected in backends.py. Unless you wrote verify=False, you are not effected by this change.
Andrew-Chen-Wang
changed the title
This was referenced Dec 24, 2020
Closed
Closed
allanlewis
added a commit
to allanlewis/django-rest-framework-simplejwt
that referenced
this pull request
Jan 12, 2021
Commit 073d83c added initial support for PyJWT>=2.0.0a1; full support for PyJWT>=2.0.0 should come with jazzband#349. However, we should still support PyJWT v1, at least the latest v1.7.1. This commit therefore adds axes to tox to test against both versions.
allanlewis
added a commit
to allanlewis/django-rest-framework-simplejwt
that referenced
this pull request
Jan 12, 2021
Commit 073d83c added initial support for PyJWT>=2.0.0a1; full support for PyJWT>=2.0.0 should come with jazzband#349. However, we should still support PyJWT v1, at least the latest v1.7.1. This commit therefore adds axes to tox to test against both versions.
|
@catalincoroeanu Only other maintainers can merge to master (so if David made a PR, I would have to merge). If you don't mind merging this PR, that'd be great! |
This was referenced Feb 22, 2021
Merged
|
Superseded. |
allanlewis
added a commit
to allanlewis/django-rest-framework-simplejwt
that referenced
this pull request
Feb 23, 2021
Commit 073d83c added initial support for PyJWT>=2.0.0a1; full support for PyJWT>=2.0.0 should come with jazzband#349. However, we should still support PyJWT v1, at least the latest v1.7.1. This commit therefore adds axes to tox to test against both versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleJWT 4.6.0 already support sPyJWT 2.0.0. Investigation just shows that we merged PRs for the alpha versions ahead of time, but our CI wasn't using the alpha versions so the tests never failed until the mature 2.0.0 came out. Tests just failed, but a quick adjustment to the tests without adjustments to the actual library shows everything passing.
dict.copy()).verify_signature. This is reflected in backends.py. Unless you wrote verify=False, you are not effected by this change as we will continue to use the verify keyword.