Add automated tests for Django 4.0 and DRF 3.13 #500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew-Chen-Wang
requested changes
Jan 4, 2022
There was a problem hiding this comment.
Please remove support for Django 3.1. Thank you! Also add this PR to the changelog.
Sorry, forgot to mention: yes, dropping EOL version would be great since I don't have to keep maintaining it and it is expected for everyone to upgrade past an EOL version, both for Python and Django. EOL versions are EOL because security patches won't be included anymore.
.github/workflows/test.yml
Outdated
| django-version: '2.2' | ||
| - python-version: '3.10' | ||
| django-version: '3.1' | ||
| django-version: ['2.2', '3.1', '3.2', '4.0', 'main'] |
There was a problem hiding this comment.
Please remove django 3.1
Suggested change
| django-version: ['2.2', '3.1', '3.2', '4.0', 'main'] | |
| django-version: ['2.2', '3.2', '4.0', 'main'] |
tox.ini
Outdated
| @@ -19,11 +19,13 @@ DJANGO= | |||
| 3.0: dj30 | |||
| 3.1: dj31 | |||
There was a problem hiding this comment.
Suggested change
| 3.1: dj31 |
Andrew-Chen-Wang
requested changes
Jan 6, 2022
| django-version: '2.2' | ||
| - python-version: '3.10' | ||
| django-version: '3.1' | ||
| django-version: ['2.2', '3.2', '4.0', 'main'] |
There was a problem hiding this comment.
Please include the excludes in the matrix section to reduce the number of workers.
|
Closed as #495 has been merged. Thank you though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make sure this module is working with latest Django and DRF releases so I added these versions to the configs.
Tell me if I'm wrong but I think that it adds no benefit to exclude untested version's combinations from the matrix in the test github workflow.
I made less but similar changes than in #495 (saw it afterwards sorry).