Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions. #23

Merged
merged 7 commits into from May 27, 2022
Merged

Migrate to GitHub Actions. #23

merged 7 commits into from May 27, 2022

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented May 24, 2022

Refs #13.

jezdez and others added 7 commits May 24, 2022 17:11
Use pytest.Node.from_parent() factory methods instead
of using the constructor directly.

Before I was getting
```
Direct construction of DocoptTestItem has been deprecated, please use DocoptTestItem.from_parent.
See https://docs.pytest.org/en/stable/deprecations.html#node-construction-changed-to-node-from-parent for more details.
```
and the similar
```
Direct construction of DocoptTestFile has been deprecated, please use DocoptTestFile.from_parent.
See https://docs.pytest.org/en/stable/deprecations.html#node-construction-changed-to-node-from-parent for more details.
```

which I think was the issue mentioned in #11

Now pytest passes without any warnings.
Per https://docs.codecov.com/docs/supported-report-formats,
codecov doesn't support the default `.coverage` report file that's
generated. So we should create
the `coverage.xml` in addition.
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #23 (4990ad4) into master (7e6623b) will increase coverage by 2.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   97.75%   99.79%   +2.04%     
==========================================
  Files           1        1              
  Lines         490      491       +1     
  Branches      153        0     -153     
==========================================
+ Hits          479      490      +11     
- Misses          0        1       +1     
+ Partials       11        0      -11     
Impacted Files Coverage Δ
docopt.py 99.79% <100.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae3ada...4990ad4. Read the comment docs.

@NickCrews NickCrews merged commit 0a8ab02 into master May 27, 2022
@NickCrews
Copy link
Contributor

Thank you so much @jezdez for starting this! Hopefully this was OK for me to pick up the ball, let me know if there was something I missed that we should fix up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants