dev: swap black to ruff, drop pre-commit #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 463 463
=========================================
Hits 463 463 ☔ View full report in Codecov by Sentry. |
NickCrews
force-pushed
the
drop-black
branch
2 times, most recently
from
959eecd
to
372226c
Compare
now that ruff has formatting capabilities, we can drop one more dependency. Also, the version of black and ruff in the pre-commit config was out of sync from the version pinned in pdm.lock. That is bad. So just drop pre-commit, and run stuff manually, there are only a few commands. But I can't remove it entirely, since pre-commit.ci is enabled on all jazzband repos and I can't turn it off. So there needs to be some content in there, so I added some of the generic builtin ones. I had to adjust a few of the example docstrings so that ruff wouldn't autoformat away the needed leading indentation. I was lazy and just added a bunch of `# noqa: E721` for the `type(match.value) == str` checks that should be isinstance() checks, because when I tried isinstance, some tests failed. The current method isn't that egregious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that ruff has formatting capabilities, we can drop one more dependency.
This also means that pre-commit is a bit overkill.
Also, the version of black and ruff in the pre-commit config was
out of sync from the version pinned in pdm.lock. That is bad.
So just drop pre-commit, and run stuff manually, there
are only a few commands.
I had to adjust a few of the example docstrings
so that ruff wouldn't autoformat away the needed leading indentation.
I was lazy and just added a bunch of
# noqa: E721for thetype(match.value) == strchecks that should be isinstance()checks, because when I tried isinstance, some tests failed.
The current method isn't that egregious.