Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposing django-taggit-serializer #91

Closed
Fohlen opened this issue Apr 5, 2018 · 8 comments
Closed

Proposing django-taggit-serializer #91

Fohlen opened this issue Apr 5, 2018 · 8 comments
Labels

Comments

@Fohlen
Copy link

Fohlen commented Apr 5, 2018

Hello there folks! On behalf of @mecodia and @glemmaPaul I am proposing to move the django-taggit-serializer project to jazzband, so that it can have more attention being paid to it in the future. Please let us know what you guys think over here:

  • will it be feasible for the jazzband organisation to handle this package?
  • what steps need to be taken in order to make this happen?
  • @glemmaPaul would of course still like to be involved in maintaining the package. Is this feasible with your community guidelines?
@nat-yaml
Copy link

nat-yaml commented Mar 9, 2020

+1

@ksitko
Copy link

ksitko commented Jul 22, 2020

Hey guys, any chance this could be further considered? django-taggit already is under jazzband's umbrella, given the rather significant popularity of django-rest-framework it seems almost like taggit is incomplete without a serializer.

@jezdez jezdez added the proposal label Oct 2, 2020
@jezdez
Copy link
Member

jezdez commented Oct 2, 2020

@Fohlen @glemmaPaul @ksitko Hey friends, this is long overdue to say the least, but yeah, this project looks like a good match.

Just join the Jazzband org on https://jazzband.co/ and transfer the repo using the regular GitHub repo transfer tool. A separate issue with TODOs to finalize the transfer will be created automatically and can be worked on once the project is under the Jazzband.

@kasteph
Copy link

kasteph commented Jan 24, 2021

Would it be possible to just have a fork of django-taggit-serializer under jazzband?

@jezdez
Copy link
Member

jezdez commented Jan 24, 2021

Would it be possible to just have a fork of django-taggit-serializer under jazzband?

Unfortunately that won't give access to the PyPI project and complicates maintenance. I would suggest to reach out to @glemmaPaul by email to figure out if glemmaPaul/django-taggit-serializer#44 is still something that they'd be interested. Alternatively I would suggest to propose the functionality to django-taggit itself.

@rtpg
Copy link

rtpg commented Apr 13, 2021

I have reached out to Paul regarding this topic. I believe that having django-taggit absorb the serializer code makes the most sense overall, as it's a pretty relevant piece of functionality.

@ksitko
Copy link

ksitko commented Apr 14, 2021

That would be best. Serialization is crucial enough to warrant its inclusion.

@rtpg
Copy link

rtpg commented Jun 30, 2021

Alright, I had tried reaching out to Paul and didn't get a response (on top of non-responses to other people on this topic).

Given the license compatibility (see this issue) for the projects, I opted for vendoring in the project and including attribution to Paul in several places in the codebase.

I believe this is following the licensing of the respective codebases correctly, and I also believe this is what makes sense on an organizational level as well (the serializer stuff was just one file, having it all in one package is just easier to maintain)

@Fohlen Fohlen closed this as completed Jun 30, 2021
regisb added a commit to regisb/course-discovery that referenced this issue Sep 9, 2021
The django-taggit-serializer library has been vendored in django-taggit,
now hosted by jazzband:
jazzband/help#91 (comment)

Thus, we can get rid of this package and simply change the import paths.
This is necessary for Django 3.2 compatibility.

Close edx/upgrades#18
uzairr pushed a commit to openedx/course-discovery that referenced this issue Sep 14, 2021
The django-taggit-serializer library has been vendored in django-taggit,
now hosted by jazzband:
jazzband/help#91 (comment)

Thus, we can get rid of this package and simply change the import paths.
This is necessary for Django 3.2 compatibility.

Close edx/upgrades#18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants