-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposing django-taggit-serializer #91
Comments
+1 |
Hey guys, any chance this could be further considered? django-taggit already is under jazzband's umbrella, given the rather significant popularity of django-rest-framework it seems almost like taggit is incomplete without a serializer. |
@Fohlen @glemmaPaul @ksitko Hey friends, this is long overdue to say the least, but yeah, this project looks like a good match. Just join the Jazzband org on https://jazzband.co/ and transfer the repo using the regular GitHub repo transfer tool. A separate issue with TODOs to finalize the transfer will be created automatically and can be worked on once the project is under the Jazzband. |
Would it be possible to just have a fork of django-taggit-serializer under jazzband? |
Unfortunately that won't give access to the PyPI project and complicates maintenance. I would suggest to reach out to @glemmaPaul by email to figure out if glemmaPaul/django-taggit-serializer#44 is still something that they'd be interested. Alternatively I would suggest to propose the functionality to django-taggit itself. |
I have reached out to Paul regarding this topic. I believe that having django-taggit absorb the serializer code makes the most sense overall, as it's a pretty relevant piece of functionality. |
That would be best. Serialization is crucial enough to warrant its inclusion. |
Alright, I had tried reaching out to Paul and didn't get a response (on top of non-responses to other people on this topic). Given the license compatibility (see this issue) for the projects, I opted for vendoring in the project and including attribution to Paul in several places in the codebase. I believe this is following the licensing of the respective codebases correctly, and I also believe this is what makes sense on an organizational level as well (the serializer stuff was just one file, having it all in one package is just easier to maintain) |
The django-taggit-serializer library has been vendored in django-taggit, now hosted by jazzband: jazzband/help#91 (comment) Thus, we can get rid of this package and simply change the import paths. This is necessary for Django 3.2 compatibility. Close edx/upgrades#18
The django-taggit-serializer library has been vendored in django-taggit, now hosted by jazzband: jazzband/help#91 (comment) Thus, we can get rid of this package and simply change the import paths. This is necessary for Django 3.2 compatibility. Close edx/upgrades#18
Hello there folks! On behalf of @mecodia and @glemmaPaul I am proposing to move the django-taggit-serializer project to jazzband, so that it can have more attention being paid to it in the future. Please let us know what you guys think over here:
The text was updated successfully, but these errors were encountered: