Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete type hinting of piptools.repositories package #1341

Merged
merged 4 commits into from Mar 8, 2021
Merged

Complete type hinting of piptools.repositories package #1341

merged 4 commits into from Mar 8, 2021

Conversation

jdufresne
Copy link
Member

@jdufresne jdufresne commented Mar 8, 2021

Refs: #972

Changelog-friendly one-liner:

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@jdufresne jdufresne added this to the 6.0.0 milestone Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #1341 (b9d776f) into master (1d0c9b1) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
+ Coverage   99.62%   99.65%   +0.03%     
==========================================
  Files          33       33              
  Lines        2915     2923       +8     
  Branches      313      309       -4     
==========================================
+ Hits         2904     2913       +9     
  Misses          5        5              
+ Partials        6        5       -1     
Impacted Files Coverage Δ
piptools/cache.py 100.00% <100.00%> (ø)
piptools/repositories/local.py 96.72% <100.00%> (+0.49%) ⬆️
piptools/repositories/pypi.py 97.18% <100.00%> (+0.06%) ⬆️
piptools/utils.py 100.00% <100.00%> (ø)
tests/test_utils.py 100.00% <100.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d0c9b1...0d15c6e. Read the comment docs.

tests/test_utils.py Outdated Show resolved Hide resolved
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM! 👍🏼 So nice you've refactored lookup_table.

Co-authored-by: Albert Tugushev <albert@tugushev.ru>
@atugushev atugushev mentioned this pull request Mar 8, 2021
16 tasks
@jdufresne jdufresne merged commit 866afb6 into jazzband:master Mar 8, 2021
@jdufresne jdufresne deleted the more-types branch March 8, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants