Update pypi.py #1559
Closed
Update pypi.py #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes AssertionError in Python>=V3.9.6 with Pip>=22.0.1 at Line 455
for more information, see https://pre-commit.ci
Merged
18 tasks
|
@fsecada01 Hey, there's a typo on line 453 |
sparkiegeek
reviewed
Jan 31, 2022
|
It seems that with pip>=22 pip-tools removes dash normalization https://pip.pypa.io/en/stable/news/#id73 even if it was done in pip==21.2 🙄 |
nicoa
reviewed
Feb 2, 2022
piptools/repositories/pypi.py
Outdated
| else: | ||
| for handler in logger.handlers: | ||
| if isinstance(handler, logging.StreamHandler): | ||
| handler.stream = log.stream |
There was a problem hiding this comment.
while this is expected to suppress the error, this would lead to not assigning log.stream to the relevant handler anymore as it's now a different type
4 tasks
Re-inserted handler assertions; included RichPipStreamHandler from pip internal logging module. Fix idea taken from: jazzband#1558 (comment)
for more information, see https://pre-commit.ci
|
Seems like this pull request resolves the issue more effectively and passes all tests: #1567 I'll wait until the request is approved and merged so this PR can be closed. |
merwok
reviewed
Feb 3, 2022
Comment on lines
+455
to
+458
| try: | ||
| assert isinstance(handler, logging.StreamHandler) | ||
| except Exception: | ||
| assert isinstance(handler, RichPipStreamHandler) |
There was a problem hiding this comment.
Suggested change
| try: | |
| assert isinstance(handler, logging.StreamHandler) | |
| except Exception: | |
| assert isinstance(handler, RichPipStreamHandler) | |
| assert isinstance(handler, (logging.StreamHandler, RichPipStreamHandler)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AssertionError in Python>=V3.9.6 with Pip>=22.0.1 at Line 455
Addresses AssertionError with Pip V>=22.0.1 on Python V>=3.9.6.
Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.