Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CI config #1571

Closed
wants to merge 2 commits into from
Closed

Simplify CI config #1571

wants to merge 2 commits into from

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Feb 4, 2022

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Simplifies, replaces and closes #1389.

Saves 70-odd lines of config compare to master and 108 compare to #1389.


https://github.com/actions/setup-python now has pip caching built in, meaning we can remove a lot of https://github.com/actions/cache config.


https://github.com/actions/setup-python also now has 3.11-dev so we can remove https://github.com/deadsnakes/action too. One difference here:

@hugovk hugovk added maintenance Related to maintenance processes refactor Refactoring code ci Related to continuous integration tasks enhancement Improvements to functionality labels Feb 4, 2022
@webknjaz
Copy link
Member

webknjaz commented Feb 4, 2022

One difference here

Yeah, this was one reason to keep it — nightlies are not the same as tagged unstable releases.

@hugovk
Copy link
Member Author

hugovk commented Feb 6, 2022

Yup. If testing the 3.11 branch is more important I'll drop that change and keep deadsnakes (687c118), but then 3.11 isn't cached here. 🤔

@hugovk
Copy link
Member Author

hugovk commented Feb 6, 2022

Please see #1573 for an alternative.

@hugovk hugovk closed this in #1573 Mar 15, 2022
@hugovk hugovk deleted the simplify-ci-config branch May 11, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration tasks enhancement Improvements to functionality maintenance Related to maintenance processes refactor Refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants