Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract linewriter into a context manager #1698

Closed
wants to merge 2 commits into from
Closed

extract linewriter into a context manager #1698

wants to merge 2 commits into from

Conversation

graingert
Copy link
Member

@graingert graingert commented Oct 7, 2022 •
edited

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@graingert
Copy link
Member Author

simpler version of #1696

This was referenced Oct 7, 2022
Draft
Merged
@graingert graingert added the skip-changelog Avoid listing in changelog label Oct 7, 2022
@graingert graingert added this to the 6.10.0 milestone Oct 7, 2022
@graingert
Copy link
Member Author

I think this is a whole bunch of extra complexity for minimal gain

@graingert graingert marked this pull request as draft October 8, 2022 10:45
@graingert graingert closed this Nov 9, 2022
@graingert graingert deleted the extract-linewriter-into-a-context-manager-2 branch November 9, 2022 10:42
@atugushev atugushev removed this from the 6.10.0 milestone Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz

Assignees
No one assigned
Labels
skip-changelog Avoid listing in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@graingert @atugushev