Deprecate pip-compile --resolver=legacy
#1724
Conversation
for more information, see https://pre-commit.ci
atugushev
changed the title
atugushev
changed the title
pip-compile --resolver=legacy
|
Now, tests that check the exact output in stderr are failing due to the deprecation warning. I'll address that in a separate PR. |
|
Maybe try using |
@webknjaz if so, what's the motivation? |
| @@ -378,6 +378,13 @@ def cli( | |||
| if isinstance(output_file, LazyFile): # pragma: no cover | |||
| ctx.call_on_close(safecall(output_file.close_intelligently)) | |||
|
|
|||
| if resolver_name == "legacy": | |||
| log.warning( | |||
There was a problem hiding this comment.
Why not using Deprecation warnings from warning module? Somehow I find it better.
There was a problem hiding this comment.
https://docs.python.org/3/library/exceptions.html#DeprecationWarning
DeprecationWarning
Base class for warnings about deprecated features when those warnings are intended for other Python developers.
DeprecaetionWarning is intended for developers, but pip-tools prints warning for end users. Also, it is "Ignored by the default warning filters", so it should be FutureWarning or something else.
Pure subjectivity
vs
Personally, I prefer the latter.
There was a problem hiding this comment.
But I don't mind using the warning module if you feel that's better.
There was a problem hiding this comment.
I +1 because it was only an observation. I am ok with both approaches. The real benefit of warnings is that they are very easy to silence from outside the application.
|
@atugushev the motivation is that it's easier to test. Plus if you actually put the warning in the resolution code, it'd be easier to trace what to remove later. |
Resolves #1659
Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.