New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky tests that depend on verbosity level #1743
Closed
atugushev
wants to merge
3
commits into
jazzband:main
from
atugushev:fix-flaky-tests-depeding-on-verbosity
Closed
Fix flaky tests that depend on verbosity level #1743
atugushev
wants to merge
3
commits into
jazzband:main
from
atugushev:fix-flaky-tests-depeding-on-verbosity
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
log.verbosity is not thread safe. Better to pass verbosity as DI, to avoid flaky tests.
atugushev
added
tests
Testing and related things
skip-changelog
Avoid listing in changelog
labels
Nov 22, 2022
atugushev
changed the title
Fix flaky tests that depend on verbosity
Fix flaky tests that depend on verbosity level
Nov 22, 2022
ssbarnea
approved these changes
Nov 22, 2022
Open
Heh,
|
FTR: to catch failed tests that depend on logs verbosity run the following command:
|
atugushev
added a commit
to atugushev/pip-tools
that referenced
this pull request
Dec 10, 2022
4 tasks
Superseded by #1761. |
auto-merge was automatically disabled
December 10, 2022 22:44
Pull request was closed
atugushev
added a commit
to atugushev/pip-tools
that referenced
this pull request
Dec 10, 2022
atugushev
added a commit
to atugushev/pip-tools
that referenced
this pull request
Dec 10, 2022
atugushev
added a commit
to atugushev/pip-tools
that referenced
this pull request
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1720.
log.verbosity
is not thread safe. Better to pass verbosity as DI to avoid flaky tests.Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.