Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 #1879

Merged
merged 6 commits into from Jul 1, 2023
Merged

Drop support for Python 3.7 #1879

merged 6 commits into from Jul 1, 2023

Conversation

chrysle
Copy link
Contributor

@chrysle chrysle commented Jun 12, 2023

Drop support for Python 3.7 which is EOL in the end of June.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@chrysle chrysle added maintenance Related to maintenance processes backwards incompatible Backwards incompatible change ci Related to continuous integration tasks dependency Related to a dependency labels Jun 12, 2023
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump version here also, please:

- repo: https://github.com/asottile/pyupgrade
rev: v3.3.1
hooks:
- id: pyupgrade
args: [--py37-plus]

@atugushev atugushev removed the maintenance Related to maintenance processes label Jun 12, 2023
@chrysle
Copy link
Contributor Author

chrysle commented Jun 12, 2023

@atugushev Thank you, done. Maybe a list with files relevant when dropping a version can be added to the contributing guide to ease maintenance.

@webknjaz
Copy link
Member

Should we wait until the end of July, then? I don't think it costs much to merge this later, right?

@chrysle
Copy link
Contributor Author

chrysle commented Jun 12, 2023

Sounds like a good suggestion.

@chrysle
Copy link
Contributor Author

chrysle commented Jun 28, 2023

Yesterday was the last day of support.

@webknjaz
Copy link
Member

I wonder if a release could be made right before this is merged..

@atugushev
Copy link
Member

I'll prepare a release shortly.

@atugushev
Copy link
Member

atugushev commented Jun 28, 2023

FYI: the release 6.14.0 is blocked by #1863 (comment). Release drafter now suggests 7.0.0 release.

@webknjaz
Copy link
Member

webknjaz commented Jun 30, 2023

@chrysle plz add git revert 3fdee98 to this.

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go 👍🏻

@atugushev atugushev merged commit 51d9e1c into jazzband:main Jul 1, 2023
36 checks passed
@atugushev atugushev removed the dependency Related to a dependency label Jul 1, 2023
@chrysle chrysle deleted the drop-3.7 branch July 1, 2023 07:53
@atugushev atugushev added this to the 7.0.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards incompatible Backwards incompatible change ci Related to continuous integration tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants