Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync direct references with hashes #1885

Merged
merged 20 commits into from Jul 1, 2023
Merged

Sync direct references with hashes #1885

merged 20 commits into from Jul 1, 2023

Conversation

siddharthab
Copy link
Contributor

@siddharthab siddharthab commented Jun 14, 2023 •
edited by atugushev

When a direct reference is provided with hashes, use the direct reference string as the unique key for a requirement. The key can also be used for uninstalling the dist.

See the attached issue for more details on why we want to do this.

Fixes #1884.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@siddharthab siddharthab marked this pull request as ready for review June 14, 2023 08:17
chrysle
chrysle reviewed Jun 14, 2023
View reviewed changes
piptools/utils.py Outdated Show resolved Hide resolved
@chrysle chrysle added enhancement Improvements to functionality backwards incompatible Backwards incompatible change sync labels Jun 14, 2023
chrysle
chrysle reviewed Jun 14, 2023
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
@chrysle chrysle added skip-changelog Avoid listing in changelog and removed backwards incompatible Backwards incompatible change labels Jun 14, 2023
chrysle
chrysle reviewed Jun 16, 2023
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Jun 17, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
chrysle
chrysle approved these changes Jun 17, 2023
View reviewed changes
Copy link
Contributor

@chrysle chrysle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but let's wait for @webknjaz's review.

@siddharthab
Copy link
Contributor Author

@webknjaz happy to rework this in whichever form you would like. Please let me know.

@webknjaz
Copy link
Member

I'm on vacation this week. Ping me the next one.

atugushev
atugushev reviewed Jun 28, 2023
View reviewed changes
piptools/sync.py Outdated Show resolved Hide resolved
atugushev
atugushev reviewed Jun 28, 2023
View reviewed changes
tests/test_sync.py Outdated Show resolved Hide resolved
atugushev
atugushev reviewed Jun 28, 2023
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
atugushev
atugushev approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chrysle chrysle enabled auto-merge June 30, 2023 08:23
@atugushev atugushev disabled auto-merge July 1, 2023 07:59
@atugushev atugushev enabled auto-merge (squash) July 1, 2023 08:00
@atugushev atugushev merged commit e543402 into jazzband:main Jul 1, 2023
36 checks passed
@atugushev atugushev added bug Something is not working and removed enhancement Improvements to functionality skip-changelog Avoid listing in changelog labels Jul 1, 2023
@siddharthab siddharthab deleted the sync_direct_references branch July 6, 2023 04:19
@atugushev atugushev added this to the 7.0.0 milestone Jul 14, 2023
@atugushev atugushev mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

@atugushev atugushev atugushev approved these changes

@chrysle chrysle chrysle approved these changes

Assignees
No one assigned
Labels
bug Something is not working sync
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Direct references should use direct_url hashes as key for sync
4 participants
@siddharthab @webknjaz @atugushev @chrysle