Fix UnicodeDecodeError in Py2.7 #451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidovich
reviewed
Feb 9, 2017
davidovich
reviewed
Mar 30, 2017
| @@ -159,6 +160,10 @@ def _reverse_dependencies(self, cache_keys): | |||
| """ | |||
| # First, collect all the dependencies into a sequence of (parent, child) tuples, like [('flake8', 'pep8'), | |||
| # ('flake8', 'mccabe'), ...] | |||
| return lookup_table((key_from_req(Requirement.parse(dep_name)), name) | |||
| return lookup_table((key_from_req(parse(dep_name)), name) | |||
There was a problem hiding this comment.
I believe this is not related to the issue you are trying to fix. Please open another PR for the package extras related modification, and remove this commit.
|
Dealth with by #568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #433 and #434. Pretty sure this also addresses #224 and #439, though those need confirmation.
Thanks @byjott for the fix, hopefully we can get this merged quickly.