Fixed bug breaking pip-sync on Python 3, raising TypeError #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jazzband#569 Moved and renamed `resolver._dep_key` to `utils.key_from_ireq` and use it for the `InstallRequirement`s sort in `sync.sync`. In the future, we might want to change calls like `key_from_req(ireq.req)` to `key_from_ireq(ireq)`, but I'll keep the change to a minimum here for this bugfix.
vphilippon
force-pushed
the
fix-pip-sync-py3
branch
from
f75a1f8
to
cff1bcb
Compare
|
@jdufresne This works on Docker for me, can you confirm this works for you? |
|
Worked for me! Thanks for the quick fix. |
|
@vphilippon 1.10.1 is out. |
This was referenced Sep 27, 2017
This was referenced Nov 22, 2017
This was referenced Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #569
Moved and renamed
resolver._dep_keytoutils.key_from_ireqand use itfor the
InstallRequirements sort insync.sync.In the future, we might want to change calls like
key_from_req(ireq.req)tokey_from_ireq(ireq), but I'll keep thechange to a minimum here for this bugfix before doing additional tests.
Contributor checklist