Slightly improved NoCandidateFound error message. #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidovich
reviewed
Nov 24, 2017
piptools/exceptions.py
Outdated
| @@ -13,6 +13,10 @@ def __str__(self): | |||
| 'Could not find a version that matches {}'.format(self.ireq), | |||
| 'Tried: {}'.format(', '.join(str(version) for version in sorted_versions) or '(no version found at all)') | |||
| ] | |||
| if sorted_versions: | |||
| lines.append('You probably have incompatible dependencies.') | |||
There was a problem hiding this comment.
I would try to take a more neutral tone, as this seems to be accusing. How about:
There are incompatible versions in solved versions of dependencies
There was a problem hiding this comment.
You're right, I'll change that
There was a problem hiding this comment.
Updated, I rephrased a bit
vphilippon
force-pushed
the
improve-no-candidate-message
branch
from
75ec353
to
ff1c419
Compare
davidovich
reviewed
Nov 24, 2017
piptools/exceptions.py
Outdated
| if sorted_versions: | ||
| lines.append('There are incompatible versions in the resolved dependencies.') | ||
| else: | ||
| lines.append('Was the PyPi repository reachable?') |
There was a problem hiding this comment.
We know which pypi repository was tried, I would add it here. If it is an internal server, this will help diagnose errors vs public pypi. Small nit:
Is the $(pypi) repo reachable?
vphilippon
force-pushed
the
improve-no-candidate-message
branch
from
ff1c419
to
e8129c5
Compare
|
Much better ;-) LGTM |
This was referenced Nov 30, 2017
This was referenced Jan 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help a little, making the message less cryptic.
Still no "source of conflict" yet.
Fixes #352
Changelog-friendly one-liner: Slightly improved the NoCandidateFound error message.
Contributor checklist