Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-deps flag to pip-sync, which is simply passed through to pip install #987

Closed
wants to merge 1 commit into from

Conversation

AndydeCleyre
Copy link
Contributor

@AndydeCleyre AndydeCleyre commented Nov 15, 2019

--no-deps can now be provided to pip-sync, whereby --no-deps will be passed through to pip install, and un-locked deps of locked requirements will be either removed or not installed in the first place, in order to match the lockfile exactly, despite breaking package dependencies.

Changelog-friendly one-liner: pip-sync now accepts --no-deps, to match locked txts exactly, ignoring any unlocked dependencies

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@codecov
Copy link

codecov bot commented Nov 16, 2019

Codecov Report

Merging #987 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #987      +/-   ##
==========================================
+ Coverage   99.11%   99.11%   +<.01%     
==========================================
  Files          34       34              
  Lines        2360     2363       +3     
  Branches      302      303       +1     
==========================================
+ Hits         2339     2342       +3     
  Misses         11       11              
  Partials       10       10
Impacted Files Coverage Δ
tests/test_cli_sync.py 100% <ø> (ø) ⬆️
piptools/scripts/sync.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6709244...b0fafe0. Read the comment docs.

@atugushev atugushev added the enhancement Improvements to functionality label Nov 16, 2019
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks, @AndydeCleyre!

@atugushev
Copy link
Member

atugushev commented Nov 16, 2019

@AndydeCleyre

Just wondering, why do you prefer to mark tasks this way:

[✓] Provided the tests for the changes.

instead of

[x] Provided the tests for the changes.

wich is the current Github's markdown syntax? See the doc.

With the first one we get this progress bar on PRs list (note the progress-bar):
image

The second one marks tasks correctly (note the progress-bar):
image

@AndydeCleyre
Copy link
Contributor Author

Just wondering, why do you prefer to mark tasks this way?

Just because I never read those docs, and generally think of a check as "yes" and an x as "no," but thank you, now I know better.

@atugushev
Copy link
Member

@AndydeCleyre

There is an issue #321 the implementation of which can supersede this PR. Let me know what you think of it.

@AndydeCleyre
Copy link
Contributor Author

@atugushev If --no-deps functionality is enabled by an implementation for #321 that's great and should be merged instead. My only interest here is that there be an acceptable interface for people who don't want #907 behavior, so we can fix #896 and its sub-issue of sync behavior inconsistency.

Inviting @ulope and @Zac-HD to comment

… install when given;

Add --no-deps pass-through to test_pip_install_flags
@atugushev
Copy link
Member

Close this in favor of #1080.

@atugushev atugushev closed this Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants