Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate install-dependency from 'setuptools' #91

Closed
amdei opened this issue Jan 14, 2021 · 2 comments · Fixed by #96
Closed

Eliminate install-dependency from 'setuptools' #91

amdei opened this issue Jan 14, 2021 · 2 comments · Fixed by #96

Comments

@amdei
Copy link

amdei commented Jan 14, 2021

There is a fragment in setup.py:
https://github.com/jazzband/prettytable/blob/master/setup.py#L29

install_requires=["setuptools", "wcwidth"],

Does setuptools really necessary here?
Its presence make it difficult to convert prettytable to, for example, deb-package using fpm tool (https://github.com/jordansissel/fpm) - resulted package depends on setuptools too, what, I believe, isn't really necessary.

@hugovk
Copy link
Member

hugovk commented Jan 16, 2021

Yes, it's needed to be able to get the version number using pkg_resources: #66

But this could be replaced with importlib.metadata, in the stdlib from 3.8 and has a backport too:
https://github.com/pypa/setuptools_scm#retrieving-package-version-at-runtime

Would you like to put together a PR? Thanks!

@hugovk
Copy link
Member

hugovk commented Jan 23, 2021

Please see PR #96.

@hugovk hugovk closed this as completed in #96 Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants