Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setuptools as a dependency #66

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Add setuptools as a dependency #66

merged 1 commit into from
Oct 6, 2020

Conversation

ksunden
Copy link
Contributor

@ksunden ksunden commented Oct 6, 2020

pkg_resources is imported (to get the version number), which is provided by setuptools

@ksunden
Add setuptools as a dependency
f90103b 
`pkg_resources` is imported (to get the version number), which is provided by setuptools
@ksunden
Copy link
Contributor Author

ksunden commented Oct 6, 2020

In particular, this caused problems using flit which builds in an isolated environment, with no setuptools by default (and imports the package to get the version...)

@hugovk hugovk added the changelog: Fixed For any bug fixes label Oct 6, 2020
@hugovk hugovk merged commit 5d3cc26 into jazzband:master Oct 6, 2020
@hugovk
Copy link
Member

hugovk commented Oct 6, 2020

Thank you!

@ksunden ksunden deleted the patch-1 branch October 6, 2020 05:23
@hugovk
Copy link
Member

hugovk commented Oct 9, 2020

🚀 Released in https://pypi.org/project/prettytable/1.0.1/

@hugovk hugovk added the hacktoberfest-accepted To credit accepted Hacktoberfest PRs label Oct 9, 2020
@hugovk hugovk mentioned this pull request Jan 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog: Fixed For any bug fixes hacktoberfest-accepted To credit accepted Hacktoberfest PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ksunden @hugovk