Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for readability and avoid merge conflicts #119

Merged
merged 2 commits into from
Jun 7, 2021

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jun 7, 2021

Will help avoid and simplify resolution of merge conflicts like from #104 and #114.

Also more readable. (And save some function calls.)

@hugovk hugovk added the changelog: Changed For changes in existing functionality label Jun 7, 2021
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #119 (fad55c7) into master (ff2501d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   91.09%   91.07%   -0.03%     
==========================================
  Files           3        3              
  Lines        1707     1703       -4     
==========================================
- Hits         1555     1551       -4     
  Misses        152      152              
Flag Coverage Δ
GHA_Ubuntu 91.07% <100.00%> (-0.03%) ⬇️
GHA_Windows 91.07% <100.00%> (-0.03%) ⬇️
GHA_macOS 91.07% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/prettytable/prettytable.py 87.29% <100.00%> (-0.05%) ⬇️
tests/test_prettytable.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff2501d...fad55c7. Read the comment docs.

@hugovk hugovk merged commit 5040d3b into jazzband:master Jun 7, 2021
@hugovk hugovk deleted the refactor branch June 7, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Changed For changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant