New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widen tables with long titles #216
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… table. Recalculated this to scale the table correctly. - Added test_prettytable.test_all_lengths_equal_with_long_title() to capture this this error as well. Former behavior: ``` Without title: +---------+---------+ | field a | field b | +---------+---------+ | a1 | b1 | | a2 | b2 | +---------+---------+ With title: +-----------------------------------------------------------------+ | === 80 char str ================================================================ | +--------------------------------+--------------------------------+ | field a | field b | +--------------------------------+--------------------------------+ | a1 | b1 | | a2 | b2 | +--------------------------------+--------------------------------+ ``` ``` New behavior: With title: +-----------------------------------------------------------------------------------+ | === 80 char str ================================================================ | +-----------------------------------------+-----------------------------------------+ | field a | field b | +-----------------------------------------+-----------------------------------------+ | a1 | b1 | | a2 | b2 | +-----------------------------------------+-----------------------------------------+ ```
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 94.05% 94.19% +0.14%
==========================================
Files 5 5
Lines 2254 2258 +4
==========================================
+ Hits 2120 2127 +7
+ Misses 134 131 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hugovk
changed the title
- Tables with long titles could let the title line be wider than the table.
Widen tables with long titles
Nov 9, 2022
Thank you! |
This change broke parameter min_table_width:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recalculated this to scale the table correctly.
test_prettytable.test_all_lengths_equal_with_long_title()
to capture this this error as well.Original behavior:
New behavior: