Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Flavored Markdown for table formatting #268

Merged
merged 1 commit into from Dec 13, 2023

Conversation

mumblingMac
Copy link

Fixed markdown table formatting to comply with GitHub Flavored Markdown Specification following the details provided in issue #251.

Updated the targeted unit tests as necessary.

Manually validated the generated table could be rendered using the Live Github-Flavored Markdown Editor.

@mumblingMac mumblingMac added the changelog: Fixed For any bug fixes label Dec 12, 2023
@mumblingMac mumblingMac self-assigned this Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72d49f0) 94.21% compared to head (8cee2e0) 94.21%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files           5        5           
  Lines        2387     2387           
=======================================
  Hits         2249     2249           
  Misses        138      138           
Flag Coverage Δ
macos-latest 94.17% <100.00%> (ø)
ubuntu-latest 94.17% <100.00%> (ø)
windows-latest 94.13% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugovk hugovk changed the title Fixed markdown table formatting to comply with GitHub Flavored Markdo… Use GitHub Flavored Markdown for table formatting Dec 13, 2023
@hugovk hugovk added changelog: Changed For changes in existing functionality and removed changelog: Fixed For any bug fixes labels Dec 13, 2023
@hugovk hugovk merged commit f1288a8 into jazzband:main Dec 13, 2023
26 checks passed
@hugovk
Copy link
Member

hugovk commented Dec 13, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Changed For changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants