Added a timeout setting to use with urllib2 when retrieving an image …

…with a URL. Without the timeout setting, urllib2 will wait indefinitely for a response.
jazzband · Mar 5, 2012 · 272bf5f · 272bf5f
1 parent f446f91
commit 272bf5f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/sorl/thumbnail/conf/defaults.py b/sorl/thumbnail/conf/defaults.py
@@ -81,3 +81,6 @@
 # or height given
 THUMBNAIL_DUMMY_RATIO = 1.5
 
+# Timeout, in seconds, to use when retrieving images with urllib2
+THUMBNAIL_URL_TIMEOUT = None
+
diff --git a/sorl/thumbnail/images.py b/sorl/thumbnail/images.py
@@ -166,7 +166,7 @@ def url(self):
 
 class UrlStorage(Storage):
     def open(self, name):
-        return urllib2.urlopen(name)
+        return urllib2.urlopen(name, None, settings.THUMBNAIL_URL_TIMEOUT)
 
     def exists(self, name):
         try: