Close #263. Enable GIF support

jazzband · Feb 1, 2016 · d7af8e8 · d7af8e8
1 parent cf00d77
commit d7af8e8
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 1 deletion.
diff --git a/sorl/thumbnail/admin/compat.py b/sorl/thumbnail/admin/compat.py
@@ -35,6 +35,8 @@ def render(self, name, value, attrs=None):
                 aux_ext = str(value).split('.')
                 if aux_ext[len(aux_ext)-1].lower() == 'png':
                     ext = 'PNG'
+                if aux_ext[len(aux_ext)-1].lower() == 'gif':
+                    ext = 'GIF'
             except:
                 pass
             try:

diff --git a/sorl/thumbnail/admin/current.py b/sorl/thumbnail/admin/current.py
@@ -30,6 +30,8 @@ def render(self, name, value, attrs=None):
                 aux_ext = str(value).split('.')
                 if aux_ext[len(aux_ext) - 1].lower() == 'png':
                     ext = 'PNG'
+                elif aux_ext[len(aux_ext) - 1].lower() == 'gif':
+                    ext = 'GIF'
             except:
                 pass
             try:

diff --git a/sorl/thumbnail/base.py b/sorl/thumbnail/base.py
@@ -17,6 +17,7 @@
 EXTENSIONS = {
     'JPEG': 'jpg',
     'PNG': 'png',
+    'GIF': 'gif',
 }
 
 
@@ -54,6 +55,8 @@ def _get_format(self, source):
             return 'JPEG'
         elif file_extension == '.png':
             return 'PNG'
+        elif file_extension == '.gif':
+            return 'GIF'
         else:
             from django.conf import settings
 

diff --git a/sorl/thumbnail/conf/defaults.py b/sorl/thumbnail/conf/defaults.py
@@ -58,7 +58,7 @@
 # Thumbnail filename prefix
 THUMBNAIL_PREFIX = 'cache/'
 
-# Image format, common formats are: JPEG, PNG
+# Image format, common formats are: JPEG, PNG, GIF
 # Make sure the backend can handle the format you specify
 THUMBNAIL_FORMAT = 'JPEG'
 

diff --git a/tests/thumbnail_tests/test_backends.py b/tests/thumbnail_tests/test_backends.py
@@ -59,6 +59,7 @@ def test_with_various_formats(self):
         self.assertEqual(self.backend._get_format(FakeFile('foo.jpg')), 'JPEG')
         self.assertEqual(self.backend._get_format(FakeFile('foo.jpeg')), 'JPEG')
         self.assertEqual(self.backend._get_format(FakeFile('foo.png')), 'PNG')
+        self.assertEqual(self.backend._get_format(FakeFile('foo.gif')), 'GIF')
 
     def test_double_extension(self):
         self.assertEqual(self.backend._get_format(FakeFile('foo.ext.jpg')), 'JPEG')