Replaced vendored openpyxl by a dependency #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP: update method for syncing |
Importing tablib in setup.py to read the version number is problematic when dependencies are needed during tablib import.
Recent dependencies are dropping Python 3.2 too.
Thanks Tommy Anthony for the initial patch.
|
Seems this is ready for review. |
|
@claudep can you open this again against the master branch? sorry, doing some repo cleanup. |
|
Sure, but no need to close the pull request and create another one, I can rebase my patch and force-push it. Could you reopen? |
|
I deleted the |
|
Yes, there was something strange with that develop branch. I opened #221, hopefully against the right branch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks Tommy Anthony for the initial patch.