-
-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct order of arguments to a regex call in safe_xlsx_sheet_title #510
Conversation
… correct tests Fixes jazzband#489 Related to jazzband#490
Codecov Report
@@ Coverage Diff @@
## master #510 +/- ##
==========================================
+ Coverage 90.80% 90.82% +0.02%
==========================================
Files 28 28
Lines 2653 2660 +7
==========================================
+ Hits 2409 2416 +7
Misses 244 244
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hi is there a bugfix release planned for this change? Maybe version 3.1.1? The current latest (3.1.0) breaks exporting dataset in XLSX because of the sheet name being crushed with |
Hi, yes, I think it's time for a new release. Notable changes since 3.1.0 are this, @claudep Do you think dropping 3.6 warrants a major bump (Tablib 4.0.0) or minor (Tablib 3.2.0)? I generally go for major bumps when dropping Python versions, but I don't really mind as we're using |
(We called the 2.7 and 3.5 drops breaking changes and bumped to 1.0.0 and 3.0.0 respectively.) |
Just a little more context, I'm still stuck with python 3.6 for the few months to come. That's why I was talking about a bugfix release like 3.1.1 (I assumed semver without checking the project policy though). |
I'll stick with the 3.0.0 while I'm stuck with Python 3.6. Just my 2 cents but I would at least yank the 3.1.0 on pypi as this is a really disruptive bug. Thanks for the quick response. And also thanks for reviving this nifty project. |
3.2.0 released! https://pypi.org/project/tablib/3.2.0/ You can tell pip to ignore the Python version check with $ python3.6 -m pip install tablib==3.2.0
ERROR: Could not find a version that satisfies the requirement tablib==3.2.0 (from versions: 0.6.1, 0.6.2, 0.6.3, 0.6.4, 0.7.0, 0.7.1, 0.8.0, 0.8.1, 0.8.2, 0.8.3, 0.8.4, 0.9.0, 0.9.1, 0.9.2, 0.9.3, 0.9.4, 0.9.5, 0.9.6, 0.9.7, 0.9.8, 0.9.9, 0.9.10, 0.9.11, 0.10.0, 0.11.0, 0.11.1, 0.11.2, 0.11.3, 0.11.4, 0.11.5, 0.12.0, 0.12.1, 0.13.0, 0.14.0, 1.0.0, 1.1.0, 2.0.0, 3.0.0, 3.1.0)
ERROR: No matching distribution found for tablib==3.2.0 $ python3.6 -m pip install tablib==3.2.0 --ignore-requires-python
Collecting tablib==3.2.0
Using cached tablib-3.2.0-py3-none-any.whl (48 kB)
Installing collected packages: tablib
Attempting uninstall: tablib
Found existing installation: tablib 3.1.0
Uninstalling tablib-3.1.0:
Successfully uninstalled tablib-3.1.0
Successfully installed tablib-3.2.0 Python 3.6.12 (default, Oct 19 2020, 21:40:56)
[GCC 4.2.1 Compatible Apple LLVM 10.0.1 (clang-1001.0.46.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import tablib
>>> data = tablib.Dataset(headers=['First Name', 'Last Name', 'Age'])
>>> for i in [('Kenneth', 'Reitz', 22), ('Bessie', 'Monke', 21)]:
... data.append(i)
...
>>> print(data.export('json'))
[{"First Name": "Kenneth", "Last Name": "Reitz", "Age": 22}, {"First Name": "Bessie", "Last Name": "Monke", "Age": 21}]
>>> Or install from a specified git commit as mentioned. |
PR #490 had non-functional tests and thus an invalid order of arguments to re.sub was unnoticed.
This PR corrects the call, adds tests + applies same treatment to sheet names also when saving a databook.
Fixes #489
Related to #490