Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 3.7 #551

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Drop support for EOL Python 3.7 #551

merged 1 commit into from
Jun 8, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jun 8, 2023

Python 3.7 is EOL this month:

image

Let's drop it. I don't mind if we wait until 2023-06-27, but we're probably close enough?


Does dropping a Python warrant a major or minor bump?

I used to do major, but python_requires = >=3.8 ensures the new release only installs for the right group, and I'm now leaning towards a minor, but either is fine with me.

(If we had deprecations to drop, I'd do those at the same time and do major, but we don't.)

A recent poll on the topic favours minor:

image

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #551 (d8c7596) into master (f02ac49) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #551   +/-   ##
=======================================
  Coverage   91.40%   91.40%           
=======================================
  Files          28       28           
  Lines        2723     2723           
=======================================
  Hits         2489     2489           
  Misses        234      234           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, once again no strong opinion about minor vs major. Minor is fine for me.

@hugovk
Copy link
Member Author

hugovk commented Jun 8, 2023

Let's do minor then :)

@hugovk hugovk merged commit f953e06 into jazzband:master Jun 8, 2023
16 checks passed
@hugovk hugovk deleted the rm-3.7 branch June 8, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants