Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional requirement specifier "html" back #589

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

mdellweg
Copy link
Contributor

@mdellweg mdellweg commented Apr 3, 2024

Removing such a specifier should be considered a breaking change and be postponed to the next major release, because pip install tablib[html] fails on this. Since there are no actual dependencies to consider, an empty list is put behind that key.

fixes #588

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.66%. Comparing base (0e68ed8) to head (e8994fa).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #589   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files          28       28           
  Lines        2958     2958           
=======================================
  Hits         2741     2741           
  Misses        217      217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugovk
Copy link
Member

hugovk commented Apr 4, 2024

Please could you also add this as a bugfix in https://github.com/jazzband/tablib/blob/master/HISTORY.md in this PR, with 3.6.1 and today's date, and I'll make a new release?

Removing such a specifier should be considered a breaking change and be
postponed to the next major release, because `pip install tablib[html]`
fails on this. Since there are no actual dependencies to consider, an
empty list is put behind that key.

fixes jazzband#588
@hugovk hugovk merged commit 2c71cd4 into jazzband:master Apr 4, 2024
21 checks passed
@hugovk
Copy link
Member

hugovk commented Apr 4, 2024

Thanks!

@hugovk
Copy link
Member

hugovk commented Apr 4, 2024

Thanks, this has been released: https://pypi.org/project/tablib/3.6.1/

@mdellweg mdellweg deleted the fix_optional_dependency branch April 4, 2024 14:00
@mdellweg
Copy link
Contributor Author

mdellweg commented Apr 4, 2024

Thank you so much for pushing it through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing the html extra dependency should be considered a breaking change
2 participants