Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wagtailmenus Python 3 compatible #14

Closed
ababic opened this issue Jul 8, 2016 · 4 comments
Closed

Make wagtailmenus Python 3 compatible #14

ababic opened this issue Jul 8, 2016 · 4 comments
Milestone

Comments

@ababic
Copy link
Collaborator

ababic commented Jul 8, 2016

No description provided.

@ababic ababic changed the title Ma Python 3 compatibility Make wagtailmenus Python 3 compatibile Jul 8, 2016
@ababic ababic changed the title Make wagtailmenus Python 3 compatibile Make wagtailmenus Python 3 compatible Jul 11, 2016
@ababic ababic added this to the v1.3 milestone Jul 11, 2016
@hop
Copy link

hop commented Jul 20, 2016

What is the actual problem? The test suite seems to run fine.

@ababic
Copy link
Collaborator Author

ababic commented Jul 20, 2016

Hi @hop! I've raised it as an issue here because I simply haven't ever tested in a Python 3 environment or even thought to until recently (We use 2.7 internally, and that's all I've ever ran/developed/tested in), and want to be absolutely sure I can give things that stamp of approval.

I'm determined to manage this project responsibly and be up front with developers about what is tested and what isn't, and what is officially supported or not etc. It's essential in helping them make informed decisions about what to use for their projects.

If you're saying that everything is running/testing fine in a python 3 environment though, that's certainly good news :)

@hop
Copy link

hop commented Jul 20, 2016

I cannot speak to "all", but I successfully configured a main menu and added it to a template.

Python 3.5, wagtail 1.5, wagtailmenus 1.2.2

@ababic
Copy link
Collaborator Author

ababic commented Jul 20, 2016

@hop Thanks for the info. It turns out 3.4 and 3.5 compatibility wasn't an issue at all (confirmed by automated travis CI tests in my fork). Have now merged my pull into the master. I don't want to create a new pypi release just yet, but since compatibility isn't actually a problem, there's no urgent need for a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants