Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 4.0 compatibility #403

Closed
MrCordeiro opened this issue Dec 8, 2021 · 17 comments
Closed

Django 4.0 compatibility #403

MrCordeiro opened this issue Dec 8, 2021 · 17 comments

Comments

@MrCordeiro
Copy link
Contributor

This package should be ready to support Django 4.0 as well as drop support for unsupported Django versions.

@sowinski
Copy link

sowinski commented Dec 8, 2021

Unfortunately maintenance of this project stopped.

@MrCordeiro
Copy link
Contributor Author

@sowinski I was planning to add a PR myself, as the contributing guide says it's the preferred way of submitting PR.

@sowinski
Copy link

sowinski commented Dec 8, 2021

@MrCordeiro This would be awesome.

@sowinski
Copy link

@MrCordeiro Can you take over this repository or can you just do a fork called wagtailmenus2.0 and publishing a pip package? :)

@MrCordeiro
Copy link
Contributor Author

MrCordeiro commented Jan 12, 2022

@sowinski, I got in contact with the company that owns this package and they told me they were evaluating how to proceed with its maintenance.

I don't like the idea of forking a V2. It's too confusing for users; I would only use as a last case scenario.

I don't have the advanced knowledge of Wagtail to properly maintain it, so I could only take over temporarily. Ideally, the project could be transferred to a python group like Jazzband (or a equivalent group focused on Wagtail) that maintains projects such as this.

@sowinski
Copy link

sowinski commented Jan 13, 2022

@MrCordeiro Thank you for taking care. Please keep us up to date :)

Hopefully they will answer soon. I would like to move further to a newer Wagtail version and also a newer Django version. Django 2.2 LTS supports ends in April 2022

@sowinski
Copy link

sowinski commented Jan 31, 2022

@MrCordeiro

I don't like the idea of forking a V2. It's too confusing for users; I would only use as a last case scenario.

When is your deadline for publishing Version 2.0 :)

@MrCordeiro
Copy link
Contributor Author

MrCordeiro commented Jan 31, 2022

@MrCordeiro

When is your deadline for publishing Version 2.0 :)

@sowinski, just gave them a nudge last week. Let's give a month? What do you think?

https://twitter.com/rkhleicester/status/1486972595287302144

@MrCordeiro
Copy link
Contributor Author

We have to update the project's compatibility list. I'm thinking:

  • removing Python 3.4, 3.5, and 3.6 which no longer have support
  • adding Python 3.9 and 3.10
  • dropping Django 1.11 (also, no support)
  • adding Django 4 (obviously)

@sowinski
Copy link

I think Django < 2.2 can be removed.

Why do you want to support outdated Versions of Django? (Django 2.1 support stopped in April 2019)

@sowinski
Copy link

@MrCordeiro
When is your deadline for publishing Version 2.0 :)

@sowinski, just gave them a nudge last week. Let's give a month? What do you think?

https://twitter.com/rkhleicester/status/1486972595287302144

Django 2.2 is in 2,5 Weeks outdated. I think it is time for a fork or what do you think?

@sowinski
Copy link

@sowinski, just gave them a nudge last week. Let's give a month? What do you think?

Fork? :) I think Jazzband is not interested to do something here.
I have no experience with packages on github. But if you have some experience I can help with tests and a CI pipeline.

@aliceni81
Copy link

Have been waiting for the new release with Django 4.0 compatibility..

@tonykyriakidis
Copy link

Any updates on this? @MrCordeiro

@MrCordeiro
Copy link
Contributor Author

Any updates on this? @MrCordeiro

This issue is currently blocked by #409. The Github code already supports Django 4, but we need a Jazzband roadie to release it to PyPi

@tonykyriakidis
Copy link

This issue is currently blocked by #409. The Github code already supports Django 4, but we need a Jazzband roadie to release it to PyPi

Indeed it does! 🎉 hopefully they will release the new version to PyPi soon

@MrCordeiro
Copy link
Contributor Author

MrCordeiro commented Aug 8, 2022

wagtailmenus v3+ has Django 4 support ^_ ^

#424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants