Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipes plus Django 4 support #404

Closed
wants to merge 3 commits into from
Closed

Recipes plus Django 4 support #404

wants to merge 3 commits into from

Conversation

MrCordeiro
Copy link
Contributor

This addresses #382 and #403

  • Add support for Django 4.0
  • Fixed a typo on the fixtures
  • Add "Recipes" section with an example on how to translate a custom main menu i18n

Some caveats:

  • I was unable to upgrade tox since Wagtail 2.15 has a Django <3.3 dependencies.

When that was solved, ideally we would want to drop support from Wagtail <2.11 and Django <2.2 since they are no longer supported.

Copy link

@JeffKnorr JeffKnorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also needed to make these changes to use with Django 4. This update looks good to me--for what that's worth from some random guy on the Internet. :)

Copy link

@justinsg justinsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Django 4 support in the PR is not complete - need to remove usage of django.conf.urls.url which was deprecated in Django 3.1 and now removed in Django 4.0.

#414 does provide working Django 4 support, so perhaps reduce this PR to the recipe/docs changes only?

@MrCordeiro MrCordeiro marked this pull request as draft February 27, 2022 11:18
@MrCordeiro
Copy link
Contributor Author

Hi @justinsg, I'm waiting for #409 to be resolved before doing any further work on this PR.

That being said, there were new ideas on issue #74 that may even allow for simpler versions of the recipes added here, so I converted this PR to a draft.

@MrCordeiro
Copy link
Contributor Author

I merged #414, so I'll be abandoning this PR.

@MrCordeiro MrCordeiro closed this Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants