Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: image (wkhtmltoimage) support #51

Closed
kengruven opened this issue Apr 8, 2016 · 8 comments
Closed

Request: image (wkhtmltoimage) support #51

kengruven opened this issue Apr 8, 2016 · 8 comments

Comments

@kengruven
Copy link

PDFKit is great for converting a webpage to PDF. Another program in the same (Debian) package as it is wkhtmltoimage, which can turn a webpage into PNG/SVG/etc.

We do this, too, but since pdfkit doesn't support that yet (right?), we basically have to do most of the subprocess guts ourselves. It works, but it's less fun (and more error-prone) than pdfkit.

It would be great if PDFKit supported PNG/SVG through a similar interface so we could simplify our application, and take advantage of everything PDFKit provides for wkhtmltopdf.

@mgallagher
Copy link

+1

@freetest
Copy link

freetest commented May 7, 2016

+1

i use pdfkit.from_string(html,'out.pdf')

html include images when convert finishe . the images not in out.pdf

@ShipraShalini
Copy link

+1

4 similar comments
@liumingmusic
Copy link

+1

@hackinteach
Copy link

+1

@Mitaanshu
Copy link

+1

@DeppWang
Copy link

+1

@JazzCore
Copy link
Owner

I'll surely accept a PR for this if someone willing to make it, for now it's hard to find time even to maintain this project.

Sorry that it took so long for me to get to it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants