Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Config) Make "relative <img src> points to assets" optional #502

Open
OndraZizka opened this issue Jul 25, 2018 · 1 comment
Open

(Config) Make "relative <img src> points to assets" optional #502

OndraZizka opened this issue Jul 25, 2018 · 1 comment

Comments

@OndraZizka
Copy link
Contributor

OndraZizka commented Jul 25, 2018

Ref: https://jbake.org/docs/2.6.1/#images_path

The current behavior that relative urls (except for ./...) point to the assets may not fit all. For instance me.
I want relative URLs to point to the directory of the containing file. For absolute URL's there's, quite conveniently, / :)

So how about image.url.relativePointsToAssets=true|false? With false:

[* texy-64_med_med.gif *]    <-- /myPages/texy-64_med_med.gif
[* ./texy-64_med_med.gif *]  <-- /myPages/./texy-64_med_med.gif
[* /favicon.ico *]           <-- /favicon.ico

I have coded it and will make a PR (although this one was a bit hard; the URL handling will needs refactoring in general).

OndraZizka added a commit to OndraZizka/jbake that referenced this issue Jul 25, 2018
…rg#502

Implement Make URL fixing optional jbake-org#500
These two are hitting the same code, so it's hard to split them.
@OndraZizka OndraZizka changed the title Make "relative <img src> points to assets" optional (Config) Make "relative <img src> points to assets" optional Jul 26, 2018
@jonbullock
Copy link
Member

Linking to #459

OndraZizka added a commit to OndraZizka/jbake that referenced this issue Oct 30, 2018
…rg#502

Implement Make URL fixing optional jbake-org#500
These two are hitting the same code, so it's hard to split them.
OndraZizka added a commit to OndraZizka/jbake that referenced this issue Oct 31, 2018
imports cleanup.
Final touches.
Extract the title from the Texy documents.
Improve hasHeader(): only scan first N lines, skip #... lines, skip blank lines, test against a regex; do not require status and type if defaults are set.
Add DebugUtil with map printing, since JBake code uses maps heavily
Wrap Crawler iteration into a try/catch
Start refactoring MarkupEngine so it supports files without a header.
Make DebugUtil more generic
Improve MarkupEngine: Support no header if all values are known; Improve validation; Refactor.
Extract title from Texy documents.
Implement RawMarkupEngine: Extract title from the HTML; Normalize HTML; Pretty print HTML; Export as XHTML; Change exported charset;
Introduce `input.charset`. Fix MarkupEngine - don't return headers map if the header separator is not found.
Allow .-_ in the header names
Refactor HtmlUtil#fixImageSourceUrls(). Keeps the same behavior.
Fix jbake-org#499 file names encoding.
Implements jbake-org#500  Make URL fixing optional jbake-org#500
Refactor createUri() and createNoExtensionUri() into one.
Make index creation bit more readable (just reorder)
Make index creation bit more readable (reuse the attrib name)
Refactor Crawler#crawlSourceFile() logic around updating cache flag.
Implement ContentStore#mergeDocument(Map<String, Object>) to update docs.
Implement Make "relative <img src> points to assets" optional jbake-org#502
Implement Make URL fixing optional jbake-org#500
These two are hitting the same code, so it's hard to split them.
MarkupUtil and RawMarkupUtil cleanup DebugUtil call
Force normalize HTML files if they contain <body>.
Rename vars
Allow deduplication of title autodetected from the document's header - mark that header with a CSS class.
Fix: Storing the altered DOM wrapped in <div> resulted in this <div> being serialized too. This removes it.
Make innerXml more robust.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants