New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shutdown orient database after bake has finished. #296
Conversation
Using a local storage cache with `db.store=local` throws an exception rerunning the bake tasks. ``` :bake FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':bake'. > Cannot open local storage 'cache' with mode=rw ``` See [stacktrace](https://gist.github.com/ancho/a031859dd4a04f497c91a12a51c09c7f).
@@ -174,7 +167,7 @@ public void bake() { | |||
} | |||
} finally { | |||
db.close(); | |||
// Orient.instance().shutdown(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was removed because it caused an issue while running in JBake's watch mode... but the cause of that may have been fixed since.... could you check if this still breaks watch mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok. Yes I can do that. I'm using jbake in combination with gradle and the continous task runner. Therefor I'm not aware of this breaking the watch mode for the cli.
This should fix problem occuring using cli watch mode.
Hey Jon, yes it did break. When an instance of the Orient class gets created it calls On the long term it is better to decouple the startup and shutdown of the database from the |
Thanks @ancho and I agree this needs to be looked at long term. |
Using a local storage cache with
db.store=local
throws an exceptionrerunning the bake task.
See stacktrace.