New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to apache configurations2. load properties files with default utf-8 encoding #640
update to apache configurations2. load properties files with default utf-8 encoding #640
Conversation
1ff1e3e
to
ee64954
Compare
What's wrong with windows builds and utf-8? Test on appveyor fails with
But the properties file is utf-8
hmmm....is this java.io (UTF8) vs. java.nio (UTF-8)? |
0ed4c08
to
224672f
Compare
@jonbullock , @manikmagar |
All right. Setting jvm parameter file.encoding to UTF-8 for windows solves the issue. |
e08bb42
to
a842fbe
Compare
jbake-core/src/main/java/org/jbake/app/configuration/DefaultJBakeConfiguration.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
👍 |
a0b4584
to
604d470
Compare
use java.io canonical name UTF8 to set encoding set file.encoding jvm parameter
604d470
to
4d32d38
Compare
This is an update to apache commons configuration 2.7 which is up to date and much more configurable than 1.10.
You can now configure the encoding that should be used loading the properties file in a fluent way.
This PR makes #624 obsolete. But without the original PR we wouldn't even know that 1.10 had an encoding issue.
The only thing that is missing:
--prop-encoding
) to configure property encoding that should be used