Skip to content

Commit

Permalink
clean up notes
Browse files Browse the repository at this point in the history
  • Loading branch information
jbakse committed Jan 24, 2022
1 parent 0f25601 commit a2db568
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 8 deletions.
12 changes: 10 additions & 2 deletions notes/design_questions.md
@@ -1,6 +1,14 @@
# Design Questions

- Should the cannonical variable name for current participant shared object be "me" or "my"?
- should p5.party functions start with party? eg. partySetShared

- can p5.party function names be improved?

- should p5.party functions start with party? eg. partySetShared

- Currently shared properties are initialized in setup(), but this does potentially lead to a race condition. Would it be better to have an init-object argument on partyLoadShared()?

- does setting `shared.x = 3` send a message even if shared.x is already 3? Document answer!
- in the examples are the `shared.x = share.x || 0` style inits confusing? should they be changed to another style? link to idiom?

- does setting `shared.x = 3` send a message even if shared.x is already 3?
- Test this and document answer!
13 changes: 7 additions & 6 deletions notes/how_to.md
Expand Up @@ -5,11 +5,12 @@ Releases are automated using `np`.
1. Make sure the code is working.
1. Make sure your working directory is clean.
1. Make sure your commits are pushed.
1. make sure you have your phone, for the one-time-password.
1. Make sure you are up to date with origin.
1. Make sure you have your phone, for the one-time-password.
1. Run `npm run release`.
1. Enter one-time-password
1. Enter one-time password from Duo Mobile
1. Browser should open github release page
1. Enter name
1. Attach p5.party.zip
1. Check pre-release
1. publish
1. Enter name for release (or leave blank to use release number)
1. Attach p5.party.zip (generated by build in your working directory)
1. Check pre-release checkbox
1. Click "publish"

0 comments on commit a2db568

Please sign in to comment.