Use a configurable list of views as an alternative to @db_write

[aptiko]

Fixes #7. There is now a MULTIDB_PINNING_VIEWS setting in which views are listed. like this:

MULTIDB_PINNING_VIEWS = ('myapp.core.views.myview',
                         'anotherapp.contrib.greatapp.views.yourview')

The views listed pin the thread.

Btw, how am I supposed to run the tests for multidb? Because I'm doing it in an odd way (putting multidb in the INSTALLED_APPS of a Django application and running ./manage.py test multidb).

[jsocol]

I believe this will fail on class-based views, which don't have a __name__ attribute.

[aptiko]

Actually it's working as is with class-based views, but I added a test for it. flake8 was complaining about @override_settings, although it's not clear to me why. In any case, I changed the test logic to incorporate class-based views so I'm not using it any more.

I also removed the global variable multidb.middleware.PINNING_VIEWS, because it was preventing the tests from running normally (the global variable assumed that the value of MULTIDB_PINNING_VIEWS remains constant throughout a running instance, which is normally true but isn't so while running tests).

[aptiko]

Ping

[jsocol]

@aptiko This is strange--I just rebased this onto master and ran the tests, and this is what I got:

FAILED (errors=7, failures=1)

I'm not immediately sure why, though. I tried on both Django 1.3.7 and 1.4.5. Any chance you can run them and see if you get the same issue? It's a lot of AttributeError: 'Settings' object has no attribute 'ROOT_URLCONF' .

[aptiko]

Could you tell me how I am supposed to run the tests? Because I'm doing it in an odd way (putting multidb in the INSTALLED_APPS of a Django application and running ./manage.py test multidb).

If I try python setup.py test all I get is this:

/usr/lib/python2.6/distutils/dist.py:266: UserWarning: Unknown distribution option: 'test_requires'
  warnings.warn(msg)
running test

[jsocol]

Normally you would create a virtualenv, install the test requirements with "pip install -r requirements.txt" and then just run "fab test".

[aptiko]

OK, I fixed these tests for Django 1.4. For Django 1.3 tests don't run properly, because I'm using some functionality that was probably not there in 1.3. So one question is if we need to support 1.3 now that 1.5 is out (according to Django policy, now that 1.5 is out, 1.3 is not being supported any more).

On 1.5, however, tests don't run at all. I can't find what the problem is. It says "cannot import MasterSlaveRouter". There is some kind of circularity. When it tries to import multidb.tests.settings, it tries to import multidb.tests first—I think this is normal Python. But then multidb.tests tries to import stuff from multidb, which in turn attempts to read stuff from settings. The error occurs at line 40 of multidb/__init.__.py:

if getattr(settings, 'SLAVE_DATABASES'):

Maybe moving settings.py out of directory tests would solve the problem. If my theory is correct, however, what I can't understand is why this manifests itself only with Django 1.5.

Note that this compatibility issue also seems to exist in 7b61629; therefore it does not seem to be specific to my changes; which means this pull request could be accepted (if we don't need 1.3 compatibility) and a new issue should be opened for 1.5.

[aptiko]

I'm closing this pull request because I've messed up my fork's branches, and will create a new one in its place.