Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 1.7 breakages #61

Closed
robhudson opened this issue Oct 8, 2014 · 3 comments
Closed

Django 1.7 breakages #61

robhudson opened this issue Oct 8, 2014 · 3 comments

Comments

@robhudson
Copy link
Contributor

Django 1.7 causes jingo to break in at least one way that I've found so far.

StrAndUnicode was deprecated in 1.5 and removed in 1.7. Jingo uses this method in monkey.py. The replacement, which is to use the @python_2_unicode_compatible class decorator wouldn't work with the class base hacking that jingo does. I'm investigating a way to solve this in a backwards compatible way.

@robhudson
Copy link
Contributor Author

Pull request: #62

@jsocol
Copy link
Collaborator

jsocol commented Oct 8, 2014

It's also broken in a bigger way thanks to app loading. 

Sent from my phone, please excuse the occasional typo.

On Wed, Oct 8, 2014 at 6:57 PM, Rob Hudson notifications@github.com
wrote:

Django 1.7 causes jingo to break in at least one way that I've found so far.

StrAndUnicode was deprecated in 1.5 and removed in 1.7. Jingo uses this method in monkey.py. The replacement, which is to use the @python_2_unicode_compatible class decorator wouldn't work with the class base hacking that jingo does. I'm investigating a way to solve this in a backwards compatible way.

Reply to this email directly or view it on GitHub:
#61

@robhudson
Copy link
Contributor Author

So far I haven't seen any problems because of app loading (aside from the test runner) once I put the monkey patch in the urls.py file as recommended in the instructions. But jingo could benefit from the app loading now that it exists -- although I'm not sure how one does that in a backwards compatible way.

The pull request now adds Django 1.7 to the tox and travis test matrix and adds django.setup() to the test runner so the app registry is loaded and tests run successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants