Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added support for %{deps:...} substitutions in arguments #1707

Merged
merged 1 commit into from
Nov 23, 2023
Merged

feat: added support for %{deps:...} substitutions in arguments #1707

merged 1 commit into from
Nov 23, 2023

Conversation

quintesse
Copy link
Contributor

Fixes #1703

@maxandersen
Copy link
Collaborator

this works remarkably well :)

@maxandersen maxandersen merged commit f79a0f2 into jbangdev:main Nov 23, 2023
11 checks passed
@quintesse
Copy link
Contributor Author

Yea, although I only implemented this for the %{ ... } and not the simpler %... form... and now I'm wondering if that was wise. Perhaps we should just support %deps:... as well?

@quintesse quintesse deleted the deps_arg_subst branch November 23, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxandersen maxandersen Awaiting requested review from maxandersen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support generating classpaths embedded on command line
2 participants
@quintesse @maxandersen