Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #1721

Merged
merged 1 commit into from
Feb 10, 2024
Merged

chore: update deps #1721

merged 1 commit into from
Feb 10, 2024

Conversation

cstamas
Copy link
Contributor

@cstamas cstamas commented Dec 21, 2023

And get rid of javadoc and deprecation warnings.

And get rid of javadoc and deprecation warnings.
@cstamas
Copy link
Contributor Author

cstamas commented Dec 21, 2023

Interesting, on this branch I get on console stuff like this:

Exception in thread "Worker-4" java.lang.NoClassDefFoundError: org/eclipse/osgi/framework/log/FrameworkLogEntry
        at org.eclipse.core.internal.runtime.PlatformLogWriter.getLog(PlatformLogWriter.java:88)
        at org.eclipse.core.internal.runtime.PlatformLogWriter.logging(PlatformLogWriter.java:47)
        at org.eclipse.core.internal.runtime.RuntimeLog.log(RuntimeLog.java:100)
        at org.eclipse.core.internal.jobs.Worker.run(Worker.java:91)
Caused by: java.lang.ClassNotFoundException: org.eclipse.osgi.framework.log.FrameworkLogEntry
        at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:476)
        at com.diffplug.spotless.FeatureClassLoader.findClass(FeatureClassLoader.java:81)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:594)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527)
        ... 4 more

But locally build passes? Also unsure why or where are these needed?

@cstamas cstamas marked this pull request as ready for review January 15, 2024 18:44
@maxandersen maxandersen merged commit 314bcf2 into jbangdev:main Feb 10, 2024
11 checks passed
@maxandersen
Copy link
Collaborator

not seeing those errors in logs? merging because the changes shouldn't break things YOLO.

@cstamas cstamas deleted the chore-update-deps branch April 13, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants