Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate #[must_use] for getters #40

Closed
SOF3 opened this issue Oct 22, 2019 · 1 comment
Closed

Generate #[must_use] for getters #40

SOF3 opened this issue Oct 22, 2019 · 1 comment
Assignees
@Hoverbear
Labels
enhancement proposal

Comments

@SOF3
Copy link

SOF3 commented Oct 22, 2019

Getters don't make sense if their values are unused, and most likely implies a forgotten bug or a misunderstanding of the API.

I am not sure whether marking a function #[must_use] breaks semver BC, but it would be healthy to add more #[must_use].
@Hoverbear
Copy link
Collaborator

Whoa! I knew you could use it for structures, didn't know you could use it for functions!

@Hoverbear Hoverbear self-assigned this Nov 16, 2019
@Hoverbear Hoverbear mentioned this issue Nov 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hoverbear Hoverbear

Labels
enhancement proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Must use jbaublitz/getset
2 participants
@Hoverbear @SOF3