New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support some new features from the updated spec #25
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
[submodule "spec"] | ||
path = spec | ||
url = https://github.com/jbboehr/mustache-spec.git | ||
url = https://github.com/mustache/spec.git |
Submodule spec
updated
22 files
+0 −1 | .gitattributes | |
+20 −0 | LICENSE | |
+9 −3 | Rakefile | |
+25 −26 | TESTING.md | |
+106 −1 | specs/comments.json | |
+6 −0 | specs/comments.yml | |
+132 −1 | specs/delimiters.json | |
+391 −1 | specs/interpolation.json | |
+58 −0 | specs/interpolation.yml | |
+227 −1 | specs/inverted.json | |
+6 −0 | specs/inverted.yml | |
+139 −1 | specs/partials.json | |
+367 −1 | specs/sections.json | |
+50 −5 | specs/sections.yml | |
+0 −1 | specs/utf8.json | |
+0 −18 | specs/utf8.yml | |
+316 −0 | specs/~dynamic-names.json | |
+377 −0 | specs/~dynamic-names.yml | |
+250 −0 | specs/~inheritance.json | |
+237 −0 | specs/~inheritance.yml | |
+212 −1 | specs/~lambdas.json | |
+30 −0 | specs/~lambdas.yml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may be better handled in the specification parsing code, as I don't think it's optimal to generally treat a string containing "null" as empty. Unfortunately, libyaml, being a c, not a c++, library, is fairly low level and doesn't handle any type conversions automatically. See e.g. #18.
This (probably) isn't an issue with the PHP extension as it has it's own conversion code using native PHP types.
I've opened another PR in #26 with this change applied but let me know if you disagree or if it breaks your use-case or w/e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, I think I just misinterpreted the spec there and didn't realize that was only for literal nulls.