Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warnings #38

Merged
merged 3 commits into from
Jun 9, 2017
Merged

Build warnings #38

merged 3 commits into from
Jun 9, 2017

Conversation

remicollet
Copy link
Contributor

Too much build warnings introduce noise which can hide serious issues.
This fix all of them, even if some are mostly false-positive from the compiler.

@remicollet
Copy link
Contributor Author

Of course, need to be reviewed carefully.
and yes, I build everything using -Wall ;)

@@ -79,7 +79,7 @@ zend_module_entry mustache_module_entry = {
(char *) PHP_MUSTACHE_NAME, /* Name */
NULL, /* Functions */
PHP_MINIT(mustache), /* MINIT */
NULL, /* MSHUTDOWN */
PHP_MSHUTDOWN(mustache), /* MSHUTDOWN */
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that was bad.

@coveralls
Copy link

coveralls commented Jun 9, 2017

Coverage Status

Coverage increased (+0.05%) to 89.305% when pulling d9d5d71 on remicollet:issue-warn into e125067 on jbboehr:master.

@jbboehr
Copy link
Owner

jbboehr commented Jun 9, 2017

LGTM

@jbboehr jbboehr merged commit 22027c1 into jbboehr:master Jun 9, 2017
@remicollet
Copy link
Contributor Author

Thanks

@remicollet remicollet deleted the issue-warn branch June 9, 2017 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants