Build warnings #38
Merged
Build warnings #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fined but not used [-Wunused-function]
|
Of course, need to be reviewed carefully. |
jbboehr
reviewed
Jun 9, 2017
| @@ -79,7 +79,7 @@ zend_module_entry mustache_module_entry = { | |||
| (char *) PHP_MUSTACHE_NAME, /* Name */ | |||
| NULL, /* Functions */ | |||
| PHP_MINIT(mustache), /* MINIT */ | |||
| NULL, /* MSHUTDOWN */ | |||
| PHP_MSHUTDOWN(mustache), /* MSHUTDOWN */ | |||
|
LGTM |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too much build warnings introduce noise which can hide serious issues.
This fix all of them, even if some are mostly false-positive from the compiler.